Skip to content

Conversation

pboothe
Copy link
Contributor

@pboothe pboothe commented Apr 2, 2019

This change is Reviewable

@pboothe pboothe requested a review from gfr10598 April 2, 2019 14:58
Copy link

@gfr10598 gfr10598 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: One suggestion.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @gfr10598 and @pboothe)


Dockerfile, line 13 at r1 (raw file):

# By default, alpine has no root certs. Add them so pusher can use PKI to
# verify that Google Cloud Storage is actually Google Cloud Storage.
RUN apk add --no-cache ca-certificates

Documentation in google cloud stackdriver profiler suggests:
RUN apk update
&& apk add --no-cache ca-certificates

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 297

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 295: 0.0%
Covered Lines: 411
Relevant Lines: 411

💛 - Coveralls

@pboothe
Copy link
Contributor Author

pboothe commented Apr 2, 2019

Documentation is out of date. The --no-cache option is intended to eliminate the need for apk update

@pboothe pboothe merged commit 18ea285 into master Apr 2, 2019
@pboothe pboothe deleted the add-certs branch April 2, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants