Skip to content

Conversation

pboothe
Copy link
Contributor

@pboothe pboothe commented Nov 19, 2019

Fixes #69


This change is Reviewable

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 355

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 353: 0.0%
Covered Lines: 482
Relevant Lines: 482

💛 - Coveralls

Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


tarfile/tarfile.go, line 173 at r1 (raw file):

	// the risk of unreadable files. If too-large files become a problem, delete
	// everything up to the declaration of the header and then replace the
	// `io.Copy(t.tarWriter, contents)` line with `io.Copy(tarWriter, file)`.

Anecdotally, when we were running with pcap collection in sandbox one of the patterns we saw was a surge in memory in packet-headers followed by a surge of activity from pusher. I got the impression that packet-headers created some big files for high-speed clients. Just to say this may be a recurring theme during the load testing.

@pboothe pboothe merged commit 4e63166 into master Nov 19, 2019
@pboothe pboothe deleted the fix-read branch November 19, 2019 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.Read doesn't always work
3 participants