Skip to content

Conversation

cristinaleonr
Copy link
Contributor

@cristinaleonr cristinaleonr commented Dec 22, 2021

@coveralls
Copy link

coveralls commented Dec 22, 2021

Pull Request Test Coverage Report for Build 231

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.846%

Totals Coverage Status
Change from base Build 220: 0.0%
Covered Lines: 495
Relevant Lines: 719

💛 - Coveralls

@cristinaleonr cristinaleonr changed the title Increase workers to 6 Decrease workers for hopannotation1 export Dec 23, 2021
Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: - the volume of traceroute data varies over time. when you run this end to end in staging keep an eye out for the period around when @SaiedKazemi deployed bug fixes to traceroute caller that increased the test volume. He can help identify the likely date. I think it was in June/July timeframe.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

Copy link
Contributor Author

@cristinaleonr cristinaleonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will keep an eye out for that!

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@cristinaleonr cristinaleonr merged commit 0cee4cc into master Dec 23, 2021
@cristinaleonr cristinaleonr deleted the sandbox-cristinaleon-hopannotation1-k8s-settings branch December 23, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants