Skip to content

Add version flag #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2019
Merged

Add version flag #68

merged 1 commit into from
Apr 8, 2019

Conversation

pboothe
Copy link
Contributor

@pboothe pboothe commented Apr 2, 2019 •
edited by gfr10598
Loading

@pboothe pboothe requested a review from stephen-soltesz April 2, 2019 21:43
stephen-soltesz
stephen-soltesz approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

Dockerfile, line 38 at r1 (raw file):

# flag of the form --output=dir, and we expect all users should pass in that
# flag.
WORKDIR /home

I feel like the /home workdir is out of the ordinary here. Can we remove it in favor of /?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 533

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.733%
Totals Coverage Status
Change from base Build 531: 0.0%
Covered Lines: 657
Relevant Lines: 824
💛 - Coveralls

@pboothe
Copy link
Contributor Author

pboothe commented Apr 2, 2019

Talked through the comment offline. Leaving as is.

@pboothe pboothe merged commit 5774046 into master Apr 8, 2019
@pboothe pboothe deleted the add-version-metric branch April 8, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@stephen-soltesz stephen-soltesz stephen-soltesz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pboothe @coveralls @stephen-soltesz