separate metadata from snapshots #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 681
💛 - Coveralls |
pboothe
reviewed
Jun 3, 2019
There was a problem hiding this comment.
No metadata at all is better than a weird first row of metadata.
Reviewable status: 0 of 1 LGTMs obtained
pboothe
approved these changes
Jun 3, 2019
complete! 1 of 1 LGTMs obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In BQ, we want to collect all snapshots as a repeated field in a single row for each test. This separates the metadata from the snapshots, so that it can be placed in the top level fields of the row.
This means that the metadata will no longer appear in the CVS rows. To make up for this, the CSV tool will print metadata before the CSV header and snapshot data.
This change is