Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install_gcloud now can install components #11

Merged
merged 2 commits into from
May 23, 2017

Conversation

pboothe
Copy link
Contributor

@pboothe pboothe commented May 23, 2017

Now kubectl can be installed with everything else


# Install components
gcloud config set core/disable_prompts true
for COMPONENT in $*; do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use "$@" instead of $*.

See for example the behavior of:

#!/bin/bash

for i in $* ; do
  echo '$*' $i
done

for i in "$@" ; do
  echo '$@' $i
done

Called with:

$ ./t.sh "a b" "c d"
$* a
$* b
$* c
$* d
$@ a b
$@ c d

@stephen-soltesz
Copy link
Contributor

Thank you.

LGTM, with a small change.

@pboothe pboothe merged commit 92b6e27 into m-lab:master May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants