Parses gs:// urls correctly now. #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also eliminates a bug where the md5 might not encode to a valid UTF8 string to use as a prometheus label
stephen-soltesz
approved these changes
Feb 13, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @pboothe and @stephen-soltesz)
zipfile/provider.go, line 98 at r1 (raw file):
case "gs": client, err := storage.NewClient(ctx) filename := u.Path
I expected you to use strings.TrimPrefix inline. It's a noop if the "/" is missing & saves two lines.
pboothe
commented
Feb 13, 2020
There was a problem hiding this comment.
Reviewable status:
zipfile/provider.go, line 98 at r1 (raw file):
Previously, stephen-soltesz (Stephen Soltesz) wrote…
I expected you to use
strings.TrimPrefixinline. It's a noop if the "/" is missing & saves two lines.
TIL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also eliminates a bug where the md5 might not encode to a valid UTF8 string to use as a prometheus label
This change is