Work around Migen's finalization being subtly order dependent #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, in Migen, if the module tree looks like this:
and finalizing
microscope
makes the module tree look like this:whether any Verilog will actually be generated for
ps_arm
isdependent on traversal order of submodules, which cannot be
relied upon. This causes
microscope /dev/ttyX singles
to hang.Avoid this by making finalization of probes order-independent.
@sbourdeauducq Not only this broke
microscope
in a nasty way, but this is one of the worst footguns in Migen that I've hit constantly in Glasgow... I think something should be done about it.