-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beautify gcm analogue #83
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Here's something I need help with: Current implementation:We say we are comparing linear polynomial approximation, Wilks (2005)’ polynomial parameterization and the “truth” values of the coupling terms but the legend shows only two values. Possible fix:This maps each color plotted to the label "Truth values". It is not visually pleasing but correct. Suggestions are welcome!! |
I don't think it is necessary to label the colored dots. They all represent the same thing, and it is quite clear from the text what they are.
|
for more information, see https://pre-commit.ci
I have made some changes to the text for improved readability. There are some remaining issues that should be resolved in a future PR, at the moment I have opened them as problems in issue #89 |
@IamShubhamGupto - I am not sure what I messed up, but the build above is not working. Can you please check and fix what happened? |
Hey @dhruvbalwada Sure, I will get back to this branch soon |
RCA on the build issue: Cause:
Fix:
|
Changes: