Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beautify gcm analogue #83

Merged
merged 15 commits into from
Apr 5, 2023
Merged

Conversation

IamShubhamGupto
Copy link
Member

Changes:

  • Convert variable names to snake_case
  • Fixed typos and grammatical errors - sentence rewriting
  • Standardized plot legend fontsize to 7 for the whole notebook. Could follow this for other notebooks as well - depends on graphs
  • Broke cells into smaller snippets of code

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@IamShubhamGupto
Copy link
Member Author

Here's something I need help with:

Current implementation:

Screenshot 2023-02-27 at 10 46 30 PM

We say we are comparing linear polynomial approximation, Wilks (2005)’ polynomial parameterization and the “truth” values of the coupling terms but the legend shows only two values.

Possible fix:

Screenshot 2023-02-27 at 10 51 55 PM

This maps each color plotted to the label "Truth values". It is not visually pleasing but correct.

Suggestions are welcome!!

@dhruvbalwada
Copy link
Collaborator

dhruvbalwada commented Mar 1, 2023

I don't think it is necessary to label the colored dots. They all represent the same thing, and it is quite clear from the text what they are.
You can do one of two things:

  • Change all dots to same color, and don't add a label.
  • Reshape the X_copy and U_sample to a 1d array before plotting (use flatten from the next cell). This way it shows up as a single color, and you can then label it as truth value.

@dhruvbalwada
Copy link
Collaborator

I have made some changes to the text for improved readability. There are some remaining issues that should be resolved in a future PR, at the moment I have opened them as problems in issue #89

@dhruvbalwada
Copy link
Collaborator

@IamShubhamGupto - I am not sure what I messed up, but the build above is not working. Can you please check and fix what happened?

@IamShubhamGupto
Copy link
Member Author

I have made some changes to the text for improved readability. There are some remaining issues that should be resolved in a future PR, at the moment I have opened them as problems in issue #89

Hey @dhruvbalwada

Sure, I will get back to this branch soon

@IamShubhamGupto
Copy link
Member Author

IamShubhamGupto commented Mar 29, 2023

RCA on the build issue:

Cause:

Fix:

@dhruvbalwada dhruvbalwada merged commit 273d4a1 into m2lines:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants