Skip to content
This repository has been archived by the owner on Feb 28, 2019. It is now read-only.

Properly propogate validation error #58

Merged
merged 2 commits into from
Feb 2, 2018
Merged

Properly propogate validation error #58

merged 2 commits into from
Feb 2, 2018

Conversation

m-sandusky
Copy link
Contributor

Fixes issue where validation endpoint would return 500 for invalid rulesets instead of 400.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.333% when pulling dece65e on fix-validation-endpoint-error into eccd05d on master.

@coveralls
Copy link

coveralls commented Jan 31, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 57.333% when pulling 503abbc on fix-validation-endpoint-error into eccd05d on master.

xichen2020
xichen2020 approved these changes Feb 2, 2018
View reviewed changes
Copy link
Contributor

@xichen2020 xichen2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m-sandusky m-sandusky merged commit c892bc2 into master Feb 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xichen2020 xichen2020 xichen2020 approved these changes

@jskelcy jskelcy Awaiting requested review from jskelcy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-sandusky @coveralls @xichen2020