Skip to content
This repository has been archived by the owner on Feb 28, 2019. It is now read-only.

Properly propogate validation error #58

Merged
merged 2 commits into from
Feb 2, 2018
Merged

Properly propogate validation error #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dece65e
Properly propogate validation error
m-sandusky Jan 31, 2018
503abbc
Pull in changes from m3metrics
m-sandusky Feb 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions glide.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion glide.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import:
- package: github.com/m3db/m3cluster
version: 4b25af16e37d029b79bae754d35655e6be382f94
- package: github.com/m3db/m3metrics
version: 90dad18f47ecc0a655384141f0e33ea3fe02a08d
version: f5f341f95cfc8e329467d25ae82ce8b22d8546e7
- package: github.com/m3db/m3x
version: a5cc485300c733558a25e1e6c5e9dcf4dbc241c4
- package: github.com/apache/thrift
Expand Down
3 changes: 2 additions & 1 deletion service/r2/kv/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ func (s *store) ValidateRuleSet(rs *rules.RuleSetSnapshot) error {
if validator == nil {
return errNilValidator
}
return validator.ValidateSnapshot(rs)

return s.handleUpstreamError(validator.ValidateSnapshot(rs))
}

func (s *store) CreateNamespace(namespaceID string, uOpts r2.UpdateOptions) (*rules.NamespaceView, error) {
Expand Down