-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies are in the wrong order #19
Comments
Thanks for the bug report. |
Just pubbed v1.1.1, which should resolve this. |
Thanks for the quick response and the explanation! 1.1.1 does fix the issue I opened, however this new list breaks it: languages: [
"bash",
"cpp",
"go",
"java",
"javascript",
"json",
"kotlin",
"shell",
"objectivec",
"swift"
], It is the same list as before, but without "clike". It produces the following sorted list: [ 'java',
'bash',
'c',
'cpp',
'go',
'clike',
'javascript',
'json',
'kotlin',
'objectivec',
'swift' ] which is broken for the same reason: java depends on clike. We use node v10.15.2 which is < 12 as you guessed. |
When using the following list:
The final list is:
which is broken because java depends on clike.
I don't know why peerDependencies is used to order dependencies, but it seems like it works better with requires.
Related: #3
The text was updated successfully, but these errors were encountered: