Skip to content

Fix property mapping text box #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2025
Merged

Fix property mapping text box #195

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e17271b
Fix property mapping text box
ltctceplrm Jul 19, 2025
14fbbf8
Preliminary fix in rune mode for remapping
ltctceplrm Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/settings/PropertyMappingModelComponent.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
<script lang="ts">
import { run } from 'svelte/legacy';

import { PropertyMappingModel, PropertyMappingOption, propertyMappingOptions } from './PropertyMapping';
import { capitalizeFirstLetter } from '../utils/Utils';
import Icon from './Icon.svelte';
Expand All @@ -12,17 +10,16 @@

let { model, save }: Props = $props();

let validationResult: { res: boolean; err?: Error } | undefined = $state();
let validationResult: { res: boolean; err?: Error } | undefined = $derived(model.validate());

$effect(() => {
validationResult = model.validate();
});
// Use $state as a variable declaration initializer
let propertyStates = $state(model.properties.map(p => ({ ...p })));
</script>

<div class="media-db-plugin-property-mappings-model-container">
<div class="setting-item-name">{capitalizeFirstLetter(model.type)}</div>
<div class="media-db-plugin-property-mappings-container">
{#each model.properties as property}
{#each propertyStates as property, i}
<div class="media-db-plugin-property-mapping-element">
<div class="media-db-plugin-property-mapping-element-property-name-wrapper">
<pre class="media-db-plugin-property-mapping-element-property-name"><code>{property.property}</code></pre>
Expand Down Expand Up @@ -56,6 +53,10 @@
<button
class="media-db-plugin-property-mappings-save-button {validationResult?.res ? 'mod-cta' : 'mod-muted'}"
onclick={() => {
// Sync propertyStates back to model.properties
model.properties.forEach((p, i) => {
Object.assign(p, propertyStates[i]);
});
if (model.validate().res) save(model);
}}
>Save
Expand Down