Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue with multiple faces #2

Closed
machineminded opened this issue Jan 12, 2024 · 0 comments · Fixed by #3
Closed

Fix an issue with multiple faces #2

machineminded opened this issue Jan 12, 2024 · 0 comments · Fixed by #3
Assignees
@machineminded
Labels
bug Something isn't working

Comments

@machineminded
Copy link
Owner

Describe the problem
If multiple faces are present on the output image, the face swap logic fails.

Either we need to allow picking which face to swap, or just pick the first face. This bug sort of coincides with allowing changing of the inswapper parameters, so I'll probably just fix the bug by allowing the user to pick which face to swap based on index similar to roop and ReActor.
@machineminded machineminded self-assigned this Jan 12, 2024
@machineminded machineminded added the bug Something isn't working label Jan 12, 2024
@machineminded machineminded mentioned this issue Jan 12, 2024
Merged
@bjorndunkel bjorndunkel mentioned this issue Mar 11, 2024
Open
@Amit30swgoh Amit30swgoh mentioned this issue Mar 29, 2024
Closed
5 tasks
machineminded pushed a commit that referenced this issue Jul 7, 2024
@mashb1t
fix: do not set textContent on undefined when no translation was given …
3ef663c 
…#2 (lllyasviel#3046)

* fix: do not set textContent on undefined when no translation was given
machineminded pushed a commit that referenced this issue Jul 17, 2024
@mashb1t
feat: revert adding translate feature #2
d46e47a
machineminded pushed a commit that referenced this issue Jul 17, 2024
@mashb1t
chore: update packages #2
3a86fa2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@machineminded machineminded

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix/set target image index machineminded/Fooocus-inswapper
1 participant
@machineminded