[darwin] fix filesystem metrics for APFS vm partition volume #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itchyny
force-pushed
the
fix-darwin-vm-volume
branch
from
421f5d0 to
fbb45c0
Compare
itchyny
force-pushed
the
fix-darwin-vm-volume
branch
from
fbb45c0 to
4b929ce
Compare
astj
approved these changes
Aug 30, 2018
This was referenced Sep 13, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APFS creates a VM partition at /private/var/vm and the agent collects the filesystem metrics but this is totally useless. The partition size is annoying so I think we should skip the metric. The consumed capacity takes from the root disk size so I added to the used metric of the root filesystem.