-
-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Xcode project #1178
Update Xcode project #1178
Conversation
ichizok
commented
Mar 24, 2021
- Organize Vim sources
- Enable Base Internationalization
- Set "ALWAYS_SEARCH_USER_PATHS" to NO
@ichizok, is there a reason you are updating for the 2 external libraries: PSMTabBarControl and qlstephen? I think this would make updating in the future more difficult. Incidentally, I do have some thoughts on each of these:
|
About PSMTabBarControl and qlstephen, because I only have felt their build warning is annoying. |
- Organize Vim sources - Enable Base Internationalization - Set "ALWAYS_SEARCH_USER_PATHS" to NO
Ok thanks. MacVim has a lot of cruft like these that are using features deprecated years ago… It's a good thing to fix them up. Speaking of qlstephen, do you have any thoughts on it (or even know what it does)? I'm still deciding on what to do with it but if you don't have any opinions on it that's fine too. |
@ychin I use it to be honest to preview almost every file I have. Can you suggest an alternative if you're going to delete it? |
@eirnym Why can't your just install qlstephen separately from MacVim? Or is it that you want to preview files that you associated with MacVim? As I said I actually haven't really looked closely into this yet to have made a decision, but I don't think MacVim should inject non-MacVim features, such as the ability to preview a file with no extensions like Also, do note that qlstephen isn't previewing the files using MacVim. It's basically a raw text preview of the file without any Vim functionality. I'm looking into qlstephen mostly because I'm looking into #916 btw. |
ah, you mean files with no extensions... I usually don't look into these files. If I'd want to look into them, I could open them in MacVim by dragging them into. I mostly do a preview for files with known extensions like markdown, asciidoc, subtitles (ssa/srt/ass), text (which is always set to default for MacVim for me), json/xml and files with code (c/c++/c#/go/rust/python. On few macOs machines I don't have Xcode at all and MacVim is mostly the only source of quick view for these files I have With this I'd prefer the situation where a way to limit QL extension for a limited number of file types will be found leaving an ability for that in MacVim |
Part of this was originally part of macvim-dev#1178 but we removed the qlstephen parts to prepare for eventual removal. Couple years later and we haven't removed qlstephen yet, so just fix the warnings for now first. From macvim-dev#1178: - Fix the project localization name from English to "en" - Set ALWAYS_SEARCH_USER_PATHS to "NO" Also: - Remove the hard-coded macOS 10.8 deployment target which actually isn't supported by modern Xcode versions. Just unset it as our CI usually sets that for us. - THe post-build script is now tagged properly to always run. - Ignore all deprecation warnings. These were exposed because we removed the 10.8 deployment target. Since we aren't going to be fixing them (we are either just going to grab newer versions from upsteram, or delete this), there's no point in having these warnings.
Part of this was originally part of macvim-dev#1178 but we removed the qlstephen parts to prepare for eventual removal. Couple years later and we haven't removed qlstephen yet, so just fix the warnings for now first. From macvim-dev#1178: - Fix the project localization name from English to "en" - Set ALWAYS_SEARCH_USER_PATHS to "NO" Also: - Remove the hard-coded macOS 10.8 deployment target which actually isn't supported by modern Xcode versions. Just unset it as our CI usually sets that for us. - The post-build script is now tagged properly to always run. - Ignore all deprecation warnings. These were exposed because we removed the 10.8 deployment target. Since we aren't going to be fixing them (we are either just going to grab newer versions from upsteram, or delete this), there's no point in having these warnings.
Part of this was originally part of macvim-dev#1178 but we removed the qlstephen parts to prepare for eventual removal. Couple years later and we haven't removed qlstephen yet, so just fix the warnings for now first. From macvim-dev#1178: - Fix the project localization name from English to "en" - Set ALWAYS_SEARCH_USER_PATHS to "NO" Also: - Remove the hard-coded macOS 10.8 deployment target which actually isn't supported by modern Xcode versions. Just unset it as our CI usually sets that for us. - The post-build script is now tagged properly to always run. - Ignore all deprecation warnings. These were exposed because we removed the 10.8 deployment target. Since we aren't going to be fixing them (we are either just going to grab newer versions from upsteram, or delete this), there's no point in having these warnings.