Skip to content

Small changes in chapters 2 and 4 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2019
Merged

Small changes in chapters 2 and 4 #22

merged 2 commits into from
Oct 31, 2019

Conversation

franklinjosmell
Copy link
Contributor

Chapter 02: Syntax error in routes.rb
Chapter 03: Update a path
Chapter 04: Update a path and adds a missing commit

madeindjs
madeindjs requested changes Oct 31, 2019
View reviewed changes
Copy link
Owner

@madeindjs madeindjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sound great! Can you just remove the DS_Store file and eventually add it to gitignore?

@franklinjosmell
Copy link
Contributor Author

Yes, I already did it

@madeindjs
Copy link
Owner

Great. Thank you very much for your work!

@madeindjs madeindjs merged commit 96306cb into madeindjs:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madeindjs madeindjs madeindjs requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franklinjosmell @madeindjs