Skip to content

Adds some corrections in chapter 05 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2019
Merged

Adds some corrections in chapter 05 #25

merged 1 commit into from
Nov 9, 2019

Conversation

franklinjosmell
Copy link
Contributor

@franklinjosmell franklinjosmell commented Nov 7, 2019 •
edited
Loading

List of changes:

  • Delete duplicate code of User class.
  • Update wrong path for User class.
  • Delete a paragraph, because it refers to the gem FactoryBot, but the gem is never used it in the book.
  • Update the url for the gem "fast_jsonapi".

@franklinjosmell franklinjosmell changed the title Adds some corrections Adds some corrections in chapter 05 Nov 7, 2019
madeindjs
madeindjs requested changes Nov 8, 2019
View reviewed changes
@madeindjs madeindjs merged commit f570eae into madeindjs:master Nov 9, 2019
@franklinjosmell franklinjosmell deleted the changes-in-chapter-05 branch November 9, 2019 22:44
@franklinjosmell franklinjosmell restored the changes-in-chapter-05 branch November 9, 2019 23:04
@franklinjosmell franklinjosmell deleted the changes-in-chapter-05 branch November 9, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madeindjs madeindjs madeindjs requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franklinjosmell @madeindjs