-
-
Notifications
You must be signed in to change notification settings - Fork 120
Spanish translation for Rails 6 version #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all: thank you very much for your work !
I make two little comments. I also see two things to update:
- add
es
lang in rakefile: https://github.com/madeindjs/api_on_rails/blob/master/Rakefile#L4 - upload the book on leanpubas YOUR book version and add a link https://github.com/madeindjs/api_on_rails#support-the-project (if you want it of course)
- add a section "contributor" ith your name on readme: https://github.com/madeindjs/api_on_rails#license :)
rails6/es/api_on_rails.adoc
Outdated
:copyright: CC-BY-SA 4.0, MIT | ||
:keywords: Rails, API, Ruby, Software | ||
:lang: es | ||
:author: Alexandre Rousseau |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't hesitate to add you name here :)
.... | ||
$ rake test | ||
.................... | ||
.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tag seem be broken
Thank you for your comments :) |
Thank you for your work. I merge changes and create a new release on github. |
Hi! in the last week I work on tutorial translation for Spanish version, I did it only with Rails 6 version.