Skip to content

Conversation

oscartzgz
Copy link
Contributor

Hi! in the last week I work on tutorial translation for Spanish version, I did it only with Rails 6 version.

Copy link
Owner

@madeindjs madeindjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all: thank you very much for your work !

I make two little comments. I also see two things to update:

:copyright: CC-BY-SA 4.0, MIT
:keywords: Rails, API, Ruby, Software
:lang: es
:author: Alexandre Rousseau
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't hesitate to add you name here :)

Comment on lines +445 to +448
....
$ rake test
....................
....
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tag seem be broken

@oscartzgz
Copy link
Contributor Author

Thank you for your comments :)
I reviewed all your recommendations, I attended them and now I think everything is ready

@madeindjs
Copy link
Owner

Thank you for your work. I merge changes and create a new release on github.

@madeindjs madeindjs merged commit 3abde48 into madeindjs:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants