Add GitHub Action workflow to build the book #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated packages & bundler - removed 'kindlegen'. More at tdtds/kindlegen#42
madeindjs
reviewed
Aug 29, 2020
Co-authored-by: Alexandre Rousseau <contact@rousseau-alexandre.fr>
…mber Co-authored-by: Alexandre Rousseau <contact@rousseau-alexandre.fr>
madeindjs
approved these changes
Aug 31, 2020
|
@kerolloz I just merged. I made a little fix but it works 🎆 . Thank you again! |
|
Yesterday, I finished reading the book. I learned a lot. Thank you @madeindjs. |
|
Here is what I have built. Take a look at the README https://github.com/kerolloz/marketplace_api#readme |
|
Oh Great. Feel free to make PR on marketplace API too 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
action run example: https://github.com/kerolloz/api_on_rails/runs/1042903492?check_suite_focus=true
the created release with built versions for all languages and extensions(except MOBI): https://github.com/kerolloz/api_on_rails/releases/tag/untagged-2332728a3393c5c327c1
What do you think @madeindjs ? any changes?