Fix "pendingBuf overflow" assert in LIT_MEM mode #898
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since each element in s->d_buf is 2 bytes, the sx index should be multiplied by 2 in the assert. Fixes madler#897
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Dec 18, 2023
This fixes an incorrect assertion, see madler/zlib#897 The PR has been accepted upstream, but isn't published as part of the 'develop' branch yet. Bug: 1511987 Change-Id: Icedb1ff619acec63d655b54bb65d25918b7e240a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5131006 Reviewed-by: Nico Weber <thakis@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1238580}
jrguzman-ms
pushed a commit
to msft-mirror-aosp/platform.external.zlib
that referenced
this pull request
Dec 19, 2023
This fixes an incorrect assertion, see madler/zlib#897 The PR has been accepted upstream, but isn't published as part of the 'develop' branch yet. Bug: 1511987 Change-Id: Icedb1ff619acec63d655b54bb65d25918b7e240a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5131006 Reviewed-by: Nico Weber <thakis@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1238580} NOKEYCHECK=True GitOrigin-RevId: 1742eed8819e3862dcb4a618be1dca482908f365
|
Merged commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since each element in s->d_buf is 2 bytes, the sx index should be multiplied by 2 in the assert.
Fixes #897