Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"pendingBuf overflow" assert when building with the LIT_MEM define #897

Closed
zmodem opened this issue Dec 15, 2023 · 4 comments
Closed

"pendingBuf overflow" assert when building with the LIT_MEM define #897

zmodem opened this issue Dec 15, 2023 · 4 comments

Comments

@zmodem
Copy link
Contributor

zmodem commented Dec 15, 2023

At zlib ac8f12c using the attached program:
pr1511987.c.gz

$ gcc -DZLIB_DEBUG -DLIT_MEM /tmp/pr1511987.c adler32.c crc32.c deflate.c inffast.c inflate.c inftrees.c trees.c zutil.c && ./a.out
pendingBuf overflow
zmodem added a commit to zmodem/zlib that referenced this issue Dec 15, 2023
@zmodem
Fix "pendingBuf overflow" assert in LIT_MEM mode
48ca09d 
Since each element in s->d_buf is 2 bytes, the sx index should be
multiplied by 2 in the assert.

Fixes madler#897
@zmodem zmodem mentioned this issue Dec 15, 2023
Closed
@madler
Copy link
Owner

madler commented Dec 15, 2023

Thanks. Applied.

@madler madler closed this as completed Dec 15, 2023
@zmodem
Copy link
Contributor Author

zmodem commented Dec 16, 2023

I don't see where it was applied. Did it get lost, or does it need pushing or something similar?

@madler
Copy link
Owner

madler commented Dec 16, 2023

It's in my local version. It will get pushed eventually.

aarongable pushed a commit to chromium/chromium that referenced this issue Dec 18, 2023
@zmodem
[zlib] Apply madler/zlib#898
1742eed 
This fixes an incorrect assertion, see
madler/zlib#897

The PR has been accepted upstream, but isn't published as part of the
'develop' branch yet.

Bug: 1511987
Change-Id: Icedb1ff619acec63d655b54bb65d25918b7e240a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5131006
Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1238580}
jrguzman-ms pushed a commit to msft-mirror-aosp/platform.external.zlib that referenced this issue Dec 19, 2023
@zmodem @copybara-github
[zlib] Apply madler/zlib#898
beb2b58 
This fixes an incorrect assertion, see
madler/zlib#897

The PR has been accepted upstream, but isn't published as part of the
'develop' branch yet.

Bug: 1511987
Change-Id: Icedb1ff619acec63d655b54bb65d25918b7e240a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5131006
Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1238580}
NOKEYCHECK=True
GitOrigin-RevId: 1742eed8819e3862dcb4a618be1dca482908f365
@Neustradamus
Copy link

Neustradamus commented Dec 20, 2023 •
edited
Loading

@madler: I think that some commits are missing since 2023-11-15, can you push it?
Thanks in advance.

@zmodem PR: #898

madler pushed a commit that referenced this issue Jan 17, 2024
@zmodem @madler
Fix pending buffer overflow assert with LIT_MEM allocation.
ee474ff 
Since each element in s->d_buf is 2 bytes, the sx index should be
multiplied by 2 in the assert.

Fixes #897
nmoinvaz pushed a commit to nmoinvaz/zlib-ng that referenced this issue Jan 30, 2024
@zmodem @nmoinvaz
Fix pending buffer overflow assert with LIT_MEM allocation.
1414b95 
Since each element in s->d_buf is 2 bytes, the sx index should be
multiplied by 2 in the assert.

Fixes madler/zlib#897

madler/zlib#ee474ff2d11715485a87b123edbdd615ba218b88
nmoinvaz pushed a commit to nmoinvaz/zlib-ng that referenced this issue Jan 30, 2024
@zmodem @nmoinvaz
Fix pending buffer overflow assert with LIT_MEM allocation.
dab1b5f 
Since each element in s->d_buf is 2 bytes, the sx index should be
multiplied by 2 in the assert.

Fixes madler/zlib#897

madler/zlib#ee474ff2d11715485a87b123edbdd615ba218b88
nmoinvaz pushed a commit to nmoinvaz/zlib-ng that referenced this issue Jan 30, 2024
@zmodem @nmoinvaz
Fix pending buffer overflow assert with LIT_MEM allocation.
d46d572 
Since each element in s->d_buf is 2 bytes, the sx index should be
multiplied by 2 in the assert.

Fixes madler/zlib#897

madler/zlib#ee474ff2d11715485a87b123edbdd615ba218b88
nmoinvaz pushed a commit to nmoinvaz/zlib-ng that referenced this issue Feb 4, 2024
@zmodem @nmoinvaz
Fix pending buffer overflow assert with LIT_MEM allocation.
499c22e 
Since each element in s->d_buf is 2 bytes, the sx index should be
multiplied by 2 in the assert.

Fixes madler/zlib#897

madler/zlib#ee474ff2d11715485a87b123edbdd615ba218b88
Dead2 pushed a commit to zlib-ng/zlib-ng that referenced this issue Feb 7, 2024
@zmodem @Dead2
Fix pending buffer overflow assert with LIT_MEM allocation.
101589d 
Since each element in s->d_buf is 2 bytes, the sx index should be
multiplied by 2 in the assert.

Fixes madler/zlib#897

madler/zlib#ee474ff2d11715485a87b123edbdd615ba218b88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix "pendingBuf overflow" assert in LIT_MEM mode zmodem/zlib
3 participants
@Neustradamus @madler @zmodem