Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make List.repeatWith and List.range generic #145

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Make List.repeatWith and List.range generic #145

merged 1 commit into from
Apr 14, 2024

Conversation

brekk
Copy link
Contributor

@brekk brekk commented Mar 30, 2024

https://media2.giphy.com/media/RHVhmUGeeYXXa/giphy.gif?cid=6104955e5123yo95zz18qklc4ey5f9qjt9p3or81s6timd0i&ep=v1_gifs_translate&rid=giphy.gif&ct=g

@brekk brekk changed the title Aragorn Add range functions to individual Number instances Mar 30, 2024
@brekk
Copy link
Contributor Author

brekk commented Mar 30, 2024

This issue is linked as the new tests aren't format-able: #146

Copy link
Contributor

@aboeglin aboeglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m confused, why not just make List.range generic?

@brekk
Copy link
Contributor Author

brekk commented Mar 31, 2024

I’m confused, why not just make List.range generic?

Ah, I'm open to that, but my original thinking was that range seems like it ought to be not part of List at all. Short.range / Integer.range makes intuitive sense to me, but List.range feels like it's only associated with lists by happenstance.

@aboeglin
Copy link
Contributor

Well, in a way it’s a List constructor after all.

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.03%. Comparing base (3187435) to head (a5d54e4).

❗ Current head a5d54e4 differs from pull request most recent head 8a83a59. Consider uploading reports for the commit 8a83a59 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   74.00%   74.03%   +0.02%     
==========================================
  Files          81       81              
  Lines       11891    11877      -14     
==========================================
- Hits         8800     8793       -7     
+ Misses       3091     3084       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brekk brekk requested a review from aboeglin April 3, 2024 00:35
@brekk brekk changed the title Add range functions to individual Number instances Make List.repeatWith and List.range generic Apr 3, 2024
Copy link
Contributor

@aboeglin aboeglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot about that one, it can go as well!

@brekk brekk merged commit 3f29439 into master Apr 14, 2024
2 checks passed
@brekk brekk deleted the aragorn branch April 14, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants