-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make List.repeatWith
and List.range
generic
#145
Conversation
brekk
commented
Mar 30, 2024
•
edited
Loading
edited
This issue is linked as the new tests aren't format-able: #146 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m confused, why not just make List.range generic?
Ah, I'm open to that, but my original thinking was that |
Well, in a way it’s a List constructor after all. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #145 +/- ##
==========================================
+ Coverage 74.00% 74.03% +0.02%
==========================================
Files 81 81
Lines 11891 11877 -14
==========================================
- Hits 8800 8793 -7
+ Misses 3091 3084 -7 ☔ View full report in Codecov by Sentry. |
range
functions to individual Number instancesList.repeatWith
and List.range
generic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot about that one, it can go as well!