Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add difference / symmetricDifference #148

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Add difference / symmetricDifference #148

merged 1 commit into from
Apr 27, 2024

Conversation

brekk
Copy link
Contributor

@brekk brekk commented Apr 3, 2024

Functions for asserting the difference and commonality between two lists

@brekk brekk requested a review from aboeglin April 3, 2024 01:00
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.03%. Comparing base (3187435) to head (c037022).
Report is 20 commits behind head on master.

❗ Current head c037022 differs from pull request most recent head 02ca01e. Consider uploading reports for the commit 02ca01e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
+ Coverage   74.00%   74.03%   +0.02%     
==========================================
  Files          81       81              
  Lines       11891    11877      -14     
==========================================
- Hits         8800     8793       -7     
+ Misses       3091     3084       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brekk brekk marked this pull request as draft April 4, 2024 02:03
@brekk
Copy link
Contributor Author

brekk commented Apr 4, 2024

Pausing this until the weirdness is resolved

@aboeglin
Copy link
Contributor

@brekk Should be fine now.

@brekk brekk changed the title Add difference / symmetricDifference / union Add difference / symmetricDifference Apr 19, 2024
@brekk brekk marked this pull request as ready for review April 19, 2024 17:59
@brekk
Copy link
Contributor Author

brekk commented Apr 19, 2024

@aboeglin I nixed union for now, since I think writing it with Set is ultimately much more performant and not that hard to construct with composition. But otherwise I think these two difference functions are helpful as written.

@brekk brekk merged commit 9217f6b into master Apr 27, 2024
2 checks passed
@brekk brekk deleted the diffy-sniffy branch April 27, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants