Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak the Pillar of the Paruns format #11197

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

Susucre
Copy link
Contributor

@Susucre Susucre commented Sep 23, 2023

Tweaking the custom Pillar of the Paruns format.

After testing a few times, the following was modified:
-> I wanted to add a couple ability to Pillar of the Paruns. This was done here adding a custom version of the card, in an "Custom Alchemy" set. It is more straightforward than adding continuous effect to games in the custom game mode.
-> Starting life set to 25. Ideally this would be a custom option instead in the future, but I delayed working on that due to waiting a PR to be merged first.

image

@@ -533,6 +533,7 @@ public class ScryfallImageSupportCards {
add("WOE"); // Wilds of Eldraine
add("WOT"); // Wilds of Eldraine: Enchanting Tales
add("WOC"); // Wilds of Eldraine Commander
add("CALC"); // Custom Alchemized versions of existing cards. Will download the original in directDownloadLinks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's slightly confusing to add a custom set in this list. But if that's the only way for it to work, it's okay.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that first add is for "attempt to download through scryfall", then the directDownloadLinks will direct url download the pillar image from dissension to the correct folder for CALC/1

I did not want to do an heavier rework of the logic, but still have some image on the custom card.

Mage.Sets/src/mage/sets/CustomAlchemy.java Show resolved Hide resolved
Copy link
Contributor

@xenohedron xenohedron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with these workarounds- will give it a few days before merge in case anyone else has ideas for how to structure this more cleanly.

(I do eventually want to move custom cards into a different part of the file structure but since I don't have a proposal ready, not going to gate this, it'll be simple enough to move in the future.)

@Susucre
Copy link
Contributor Author

Susucre commented Sep 23, 2023

And the main reason for the custom card and not adding more to the custom mode:
In long term, I'd like to phase out the custom mode entirely.

  • 6 starting hand and 25 life would be custom options available to any match/tournament.
  • The "skip first land drop" and "conjure a C-Pillar of the Paruns" would be on a custom Emblem each player would start with. But this needs for new feature: Emblem Cards #10498 to be there first.

@xenohedron xenohedron merged commit 1acb1d6 into magefree:master Sep 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants