Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make draft logs compatible with MTGO format #5450 #5466

Merged
merged 1 commit into from
Dec 21, 2018

Conversation

hitch17
Copy link
Contributor

@hitch17 hitch17 commented Dec 20, 2018

See: #5450

I'm fairly certain that the changes I needed to get access to the set code would break the client/server protocol, so I made a few other refactors at the same time. An alternative approach would be to do a reverse lookup from the set's name to the set's code, but I think this is cleaner as long as the breaking change is acceptable.

@JayDi85
Copy link
Member

JayDi85 commented Dec 21, 2018

this is cleaner as long as the breaking change is acceptable.

Yes, it's acceptable. Also changes to Serializable classes interface will break client-server compatibility (see #4459). That's changes must be merged with new versions release like v32.

@JayDi85 JayDi85 merged commit 7b2598e into magefree:master Dec 21, 2018
@JayDi85 JayDi85 assigned hitch17 and unassigned hitch17 Dec 21, 2018
@hitch17 hitch17 deleted the mtgo-compatible-draftlogs-5450 branch September 11, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants