This repository was archived by the owner on Apr 29, 2019. It is now read-only.
94: Remove Zend_Service Dependency from CurrencyInterface #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As this was the last usage of |
bbatsche
approved these changes
Mar 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Magento\Framework\CurrencyInterface indicates a dependency on Zend_Service. This is the only dependency on Zend_Service within Magento. Additionally, this dependency is only used to perform currency conversion within an instance of Zend_Currency. This feature is not currently supported or used within Magento, and could be removed safely.
Fixed Issues (if relevant)
#94: Remove Zend_Service Dependency from CurrencyInterface
Contribution checklist