Skip to content

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Sep 24, 2019

Description (*)

Fixed Issues (if relevant)

  1. Error when loading grid after logout on adobe side #433: Error when loading grid after logout on adobe side

Manual testing scenarios (*)

  1. Login to Admin panel
    
  2. Open Adobe Stock grid (Catalog -> Categories -> Content -> Select from Gallery -> Search Adobe Stock)
    
  3. Log in to Adobe: Click "Sign in" link in top right corner (or initiate image licensing process clicking "License" button in any image preview)
    
  4. Go to adobe.com in a new tab and logout
    
  5. Return to Magento Admin panel tab, refresh it and reopen the grid
    

Grid loaded for unauthorized user

Copy link
Contributor

@diazwatson diazwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Nazar65 , thanks for this contribution.

Could you please review the integration test of this class:

There was 1 failure:
1) Magento\AdobeStockClient\Test\Integration\Model\ClientTest::testSearch
Failed asserting that 0 matches expected 3.
/home/travis/build/magento/adobe-stock-integration/ext/magento/adobe-stock-integration/AdobeStockClient/Test/Integration/Model/ClientTest.php:104

@Nazar65
Copy link
Member Author

Nazar65 commented Sep 30, 2019

hi @diazwatson i'm, currently working on this. thanks for note.

@Nazar65
Copy link
Member Author

Nazar65 commented Oct 1, 2019

@diazwatson done ✔️

sivaschenko
sivaschenko previously approved these changes Oct 9, 2019
@sivaschenko sivaschenko merged commit ccb15fe into magento:develop Oct 9, 2019
@ghost
Copy link

ghost commented Oct 9, 2019

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants