Skip to content

Conversation

konarshankar07
Copy link
Contributor

@konarshankar07 konarshankar07 commented Sep 26, 2019

Description (*)

This PR will improve the styling of the image file name save popup and added image extension as non-editable at the end of input

Fixed Issues (if relevant)

  1. Image name popup: displaying file extension separately #464: Image name popup: displaying file extension separately

Manual testing scenarios (*)

  1. Login to admin panel
  2. Open Magento Media Gallery (i.e. go to Cms -> Pages, edit the page and insert image)
  3. Click "Search Adobe Stock" button to open images grid
  4. Click on any image to expand image preview
  5. Click on "Save Preview" button
  6. Expected Result
    image

@konarshankar07
Copy link
Contributor Author

Suggestion, Can we add the overlay for the popup?
Thanks

@sivaschenko sivaschenko merged commit 2a6c793 into magento:develop Oct 1, 2019
@ghost
Copy link

ghost commented Oct 1, 2019

Hi @konarshankar07, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants