Move default premium filter to di.xml configuration #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivaschenko
requested changes
Sep 27, 2019
There was a problem hiding this comment.
Thanks for the pull request @Nazar65 ! Please see my code review comments
AdobeStockImage/etc/di.xml
Outdated
| <item name="premium_filter" xsi:type="array"> | ||
| <item name="type" xsi:type="string">premium_price_filter</item> | ||
| <item name="condition" xsi:type="string">eq</item> | ||
| <item name="field" xsi:type="string">all</item> |
There was a problem hiding this comment.
I think it's worth to try to use Magento\AdobeStockClient\Model\SearchParametersProvider\SimpleFilters for Premium filter. It should be possible after accepting the following suggestion:
Suggested change
| <item name="field" xsi:type="string">all</item> | |
| <item name="field" xsi:type="string">ALL</item> |
|
@sivaschenko done ✔️ |
sivaschenko
approved these changes
Oct 1, 2019
|
Hi @Nazar65, thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
By default premium filter is set to All in \Magento\AdobeStockClient\Model\SearchParametersProvider\Premium::apply
Instead of setting the default filter in Client, it now sets by adding the filter to Magento\AdobeStockImage\Model\GetImageList in AdobeStockImage/etc/di.xml
Fixed Issues (if relevant)
Manual testing scenarios (*)