#489 Cover \Magento\AdobeStockImage\Model\GetImageList with a unit test #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivaschenko
requested changes
Oct 13, 2019
There was a problem hiding this comment.
Thanks for your pull request @karyna-tsymbal-atwix , however, the test doe not cover major functionality of GetImageList class.
Can you please add a test(s) that is also covering situation when default filters and applied filters are not empty. I'd suggest using data provider to be able to test several default/applied filters combinations.
Thank you!
sivaschenko
approved these changes
Oct 19, 2019
|
Hi @karyna-tsymbal-atwix, thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Unit test for \Magento\AdobeStockImage\Model\GetImageList.
Issue: #489