Cover \Magento\AdobeStockImageAdminUi\Ui\Component\Listing\Filter\Color with a unit test #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivaschenko
requested changes
Oct 18, 2019
There was a problem hiding this comment.
Hi @Nazar65 thanks for the pull requests, please see review comments
| ['name' => 'name_one', 'config/colorFormat' => 'format_one'] | ||
| ); | ||
|
|
||
| $reflection = new \ReflectionClass($this->color); |
There was a problem hiding this comment.
Please pass filterData by mocking Context->getFiltersParams method instead of modifying the test class with reflection.
| */ | ||
| public function testPrepare() | ||
| { | ||
| $componentInterface = $this->createMock(\Magento\Framework\View\Element\UiComponentInterface::class); |
There was a problem hiding this comment.
Please reorganize the test to make it easier to read: use data provider and extract a couple of private methods.
|
Hi @sivaschenko done ✔️ |
sivaschenko
approved these changes
Oct 20, 2019
|
Hi @Nazar65, thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Cover \Magento\AdobeStockImageAdminUi\Ui\Component\Listing\Filter\Color with a unit test
Fixed Issues (if relevant)
Manual testing scenarios (*)
Run unit tests