This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Add clarification for what happens when you mark a block as cacheable=false #1457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
erikhansen
commented
Oct 14, 2017
erikhansen
commented
- See https://magento.stackexchange.com/a/92973/2142
- See http://alanstorm.com/magento-2-full-page-caching-code-points/
- See \Magento\Framework\View\Layout\Element::isCacheable
…=false - See https://magento.stackexchange.com/a/92973/2142 - See http://alanstorm.com/magento-2-full-page-caching-code-points/ - See \Magento\Framework\View\Layout\Element::isCacheable
jeff-matthews
suggested changes
Oct 16, 2017
| @@ -14,6 +14,6 @@ | |||
| ## Non-cacheable page checklist | |||
| - Use POST requests to modify Magento state (e.g., adding to shopping cart, wishlist, etc.) | |||
|
|
|||
| - Blocks that can't be cached should be marked as non-cacheable in the layout | |||
| - Blocks that can't be cached should be marked as non-cacheable in the layout. However be aware that if you add a non-cacheable block to a page, that page will no longer be able to be cached in the full page cache. | |||
There was a problem hiding this comment.
Suggested rewrite:
However, be aware that adding a non-cacheable block to a page prevents the full page cache from caching that page.
|
@jeff-matthews Good feedback. I've made the suggested change. |
jeff-matthews
approved these changes
Oct 16, 2017
|
Thanks @erikhansen! |
magento-cicd2
pushed a commit
that referenced
this pull request
Nov 17, 2017
1561: Added note advising devs to research DB feature compatibility
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.