Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Update xml-manage.md for meta-tag rendering #1491

Merged
merged 2 commits into from
Jun 19, 2018

Conversation

briscoda
Copy link
Contributor

@briscoda briscoda commented Oct 28, 2017

This pull update is in response to this issue: magento/magento2#10090

Because users may not realize the ability to handle this is built in, we can solve the issue with documentation as opposed to trying to create allowances for other usages.

whatsnew
Docs for meta tag rendering: https://github.com/magento/devdocs/pull/1491/files

This pull update is in response to this issue: magento/magento2#10090

Because users may not realize the ability to handle this is built in, we can solve the issue with documentation as opposed to trying to create allowances for other usages.
magento-cicd2 pushed a commit that referenced this pull request Nov 28, 2017
1573: Removed suggestion to drop security for local development
@bdenham bdenham added Site Improvements Updates to tools, processes, and site architecture that improve reader and contributor experience Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies 2.x Technical Updates to the code or processes that alter the technical content of the doc labels May 8, 2018
@bdenham bdenham requested a review from buskamuza May 8, 2018 22:08
Edited for concision and clarity.
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 31, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ bdenham
❌ briscoda

Copy link
Contributor

@bdenham bdenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice additions, @briscoda ! I made a few editorial changes for concision and clarity. Thanks, again!

@bdenham
Copy link
Contributor

bdenham commented May 31, 2018

@briscoda, after you sign the CLA, I'll merge your changes. Thanks.

@bdenham bdenham added the Waiting for Response Waiting for response from internal/external parties label Jun 1, 2018
@bdenham
Copy link
Contributor

bdenham commented Jun 12, 2018

@briscoda , just wanted to remind you that your PR is ready to be merged as soon as you sign the Contributor License Agreement. Thanks.

@bdenham bdenham merged commit f9d6c7c into magento:develop Jun 19, 2018
@bdenham bdenham removed the Waiting for Response Waiting for response from internal/external parties label Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.x Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies Site Improvements Updates to tools, processes, and site architecture that improve reader and contributor experience Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants