Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Add Video to keep update Repo #1694

Merged
merged 3 commits into from
Mar 20, 2018
Merged

Add Video to keep update Repo #1694

merged 3 commits into from
Mar 20, 2018

Conversation

osrecio
Copy link
Member

@osrecio osrecio commented Feb 6, 2018

Add video to keep update repo: https://www.youtube.com/embed/mJDCL0uzIpY

I don't know if is the best option to add directly a iframe. If you have any suggestion we can discuss about it

whatsnew

Added a descriptive video showing how to keep your fork updated with the latest changes.

Add video to keep update repo: https://www.youtube.com/embed/mJDCL0uzIpY

I don't know is the best option to add directly a iframe. If you have any suggestion we can discuss about it
bdenham pushed a commit to bdenham/devdocs that referenced this pull request Feb 8, 2018
@jeff-matthews
Copy link
Contributor

Thanks @osrecio! Instead of using an iframe, add a front matter tag to the top of the markdown file. For example:

youtube_id: mJDCL0uzIpY

@osrecio
Copy link
Member Author

osrecio commented Mar 20, 2018

Hi @jeff-matthews Thanks for Suggestion. If I add to top of markdown file. How can I add a Title of video or similar

@jeff-matthews
Copy link
Contributor

Good question. After reviewing your PR more closely, the front matter tag may not be the best solution since this isn't a standalone topic about keeping your repo up to date. I also don't think it's possible to specify a location for a video on the page using a front matter tag.

@shrielenee, please verify that the embedded video via iframe (original submission) looks good and merge.

I applied the video embed updates suggested and performed a light copyedit for consistency.
@shrielenee shrielenee added 2.x Major Update Significant original updates to existing content labels Mar 20, 2018
@shrielenee
Copy link
Contributor

Hey @osrecio - the embedded video looks good. @jeff-matthews is right: using the front matter places the video at the very top of the page, which doesn't allow for a specifying a location. Thanks for adding this helpful tidbit!

@shrielenee shrielenee merged commit 86b0465 into magento:develop Mar 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.x Major Update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants