Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update view.xml link to point to exact location #1850

Merged
merged 1 commit into from May 9, 2018

Conversation

erikhansen
Copy link
Contributor

No description provided.

@jeff-matthews jeff-matthews added 2.1.x Technical Updates to the code or processes that alter the technical content of the doc labels Apr 30, 2018
hostep pushed a commit to hostep/devdocs that referenced this pull request May 2, 2018
Add missing quote to snippet and performed general copyedit.
@bdenham
Copy link
Contributor

bdenham commented May 8, 2018

Hey @erikhansen, it looks like the link you mention is supposed to be to the luma theme view.xml as a whole because the code snippet directly under it shows the exclude node within the file. But having said that, linking directly to the exclude node of Magento's version-specific luma view.xml is probably more accurate, than the code shown in the snippet as shown here:

image

I'm inclined to remove the code snippet in favor of your direct links to the code base theme view. Is that what you're getting at here?

@bdenham bdenham added Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies and removed Technical Updates to the code or processes that alter the technical content of the doc labels May 8, 2018
Copy link
Contributor

@bdenham bdenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this change and update the code snippet later. Thanks, @erikhansen.

@bdenham bdenham merged commit f66ec67 into magento:develop May 9, 2018
@erikhansen
Copy link
Contributor Author

@bdenham My goal with this PR was to make the link take the user directly to the section of the view.xml file that showed the <exclude> code, as you noted. I think that having the <exclude> code ALSO included inline in the documentation makes sense, as a user can read through the documentation without having to click on a link to see the example code. So I would recommend leaving the documentation as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.1.x Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants