Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about the new lock-env and lock-config options #1921

Merged
merged 1 commit into from
May 22, 2018

Conversation

avstudnitz
Copy link
Contributor

@avstudnitz avstudnitz commented May 18, 2018

…for bin/magento config:set

This PR is a:

[ ] New topic
[X] Content fix or rewrite
[ ] Bug fix or improvement

Summary

When this pull request is merged, it will add information about the new lock-env and lock-config options for bin/magento config:set, how to use them and when.

Additional information

You can find more information about that topic at https://www.integer-net.com/magento-2-2-configuration-via-code/.

whatsnew
Added descriptions for the new magento config:set lock-env and lock-config options.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 18, 2018

CLA assistant check
All committers have signed the CLA.

@keharper keharper added 2.2.x Technical Updates to the code or processes that alter the technical content of the doc labels May 18, 2018
@keharper
Copy link
Contributor

keharper commented May 18, 2018

@avstudnitz Thank you for your code and documentation contributions.

A couple of questions before I start processing your pull request.

  • Has this feature been accepted for 2.3?
  • Are fields that were previously locked affected in any way?

I might need to restructure the topic to make it easier for users to find pre-2.2.4 and 2.2.4+ information, but I haven't gone through the details yet.

@keharper
Copy link
Contributor

@avstudnitz Another question: Can you specify --lock-config and --lock-env in the same command?

@keharper keharper added the Waiting for Response Waiting for response from internal/external parties label May 22, 2018
@magento-cicd2 magento-cicd2 merged commit 0c5d253 into magento:develop May 22, 2018
camdixon pushed a commit to camdixon/devdocs that referenced this pull request May 22, 2018
@keharper keharper removed the Waiting for Response Waiting for response from internal/external parties label May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.2.x Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants