Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xml-instructions.md #2173

Merged
merged 3 commits into from Jun 12, 2018
Merged

Update xml-instructions.md #2173

merged 3 commits into from Jun 12, 2018

Conversation

hitesh-wagento
Copy link
Contributor

This PR is a:

  • New topic
  • Content fix or rewrite
  • Bug fix or improvement

Summary

Correct Spelling mistake

When this pull request is merged, it will...

Additional information

@shrielenee shrielenee self-assigned this Jun 8, 2018
@shrielenee shrielenee added 2.2.x 2.3.x Magento 2.3 related changes Cleanup labels Jun 8, 2018
@shrielenee
Copy link
Contributor

Thanks @hitesh-wagento - Can you please also apply this change to v2.1 of this page? It's not symlinked to the other versions so won't get changed with this PR.

@@ -43,7 +43,7 @@ Use the following layout instructions to customize your layout:

Defines a block.

<p><b>Details:</b> A block is a unit of page output that renders some distinctive content (anything vvisually tangible for the end-user), such as a piece of information or a user interface element.
<p><b>Details:</b> A block is a unit of page output that renders some distinctive content (anything visually tangible for the end-user), such as a piece of information or a user interface element.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also change this in v2.1 version of the page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shrielenee I have already applied above changes in v2.1 2c2d39c

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hitesh-wagento - I found the PR you were referencing with your commit link. It has not been merged into production yet by our team. Please combine PR #2130 with this one and re-push up for approval. Thanks!

Typically, PRs with similar changes should be batched into one PR for easy of approval.

@shrielenee shrielenee added the Waiting for Response Waiting for response from internal/external parties label Jun 8, 2018
@shrielenee shrielenee mentioned this pull request Jun 11, 2018
3 tasks
@hitesh-wagento
Copy link
Contributor Author

Hi @shrielenee I have merged #2130 to #2173

@shrielenee shrielenee removed the Waiting for Response Waiting for response from internal/external parties label Jun 12, 2018
@shrielenee
Copy link
Contributor

Thanks for making that change @hitesh-wagento!

@shrielenee shrielenee merged commit 1e6ee4e into magento:develop Jun 12, 2018
@magento-engcom-team magento-engcom-team added the Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies label Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.1.x 2.2.x 2.3.x Magento 2.3 related changes Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants