New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update xml-instructions.md #2173
Conversation
Thanks @hitesh-wagento - Can you please also apply this change to v2.1 of this page? It's not symlinked to the other versions so won't get changed with this PR. |
@@ -43,7 +43,7 @@ Use the following layout instructions to customize your layout: | |||
|
|||
Defines a block. | |||
|
|||
<p><b>Details:</b> A block is a unit of page output that renders some distinctive content (anything vvisually tangible for the end-user), such as a piece of information or a user interface element. | |||
<p><b>Details:</b> A block is a unit of page output that renders some distinctive content (anything visually tangible for the end-user), such as a piece of information or a user interface element. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also change this in v2.1 version of the page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shrielenee I have already applied above changes in v2.1 2c2d39c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hitesh-wagento - I found the PR you were referencing with your commit link. It has not been merged into production yet by our team. Please combine PR #2130 with this one and re-push up for approval. Thanks!
Typically, PRs with similar changes should be batched into one PR for easy of approval.
Hi @shrielenee I have merged #2130 to #2173 |
Thanks for making that change @hitesh-wagento! |
This PR is a:
Summary
Correct Spelling mistake
When this pull request is merged, it will...
Additional information