Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update css_quick_guide_mode.md #2178

Merged
merged 3 commits into from Jun 12, 2018
Merged

Update css_quick_guide_mode.md #2178

merged 3 commits into from Jun 12, 2018

Conversation

hitesh-wagento
Copy link
Contributor

This PR is a: Fix typos

  • New topic
  • Content fix or rewrite
  • Bug fix or improvement

Summary

Fix typos

When this pull request is merged, it will...

Additional information

@shrielenee shrielenee self-assigned this Jun 8, 2018
@@ -44,7 +44,7 @@ The following is an illustration of how the process of making simple changes loo

![Less code redefining the color of the primary buttons]({{ site.baseurl }}/common/images/extend_less_screenshot121.png)

1. Change the button font by adding the following code in the `_extend.less` file:
1. Change the button font size by adding the following code in the `_extend.less` file:
Copy link
Contributor

@shrielenee shrielenee Jun 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add these changes to v2.2 as well, as v2.3 is symlinked to it. This way, all versions will get the change.

Copy link
Contributor

@shrielenee shrielenee Jun 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR, #2179, should be combined with this one.

@shrielenee shrielenee added Waiting for Response Waiting for response from internal/external parties 2.1.x 2.2.x 2.3.x Magento 2.3 related changes Cleanup labels Jun 8, 2018
@shrielenee
Copy link
Contributor

Also, please ensure you fill out our PR form thoroughly, including check boxes in the first section.

@shrielenee shrielenee mentioned this pull request Jun 8, 2018
3 tasks
@hitesh-wagento
Copy link
Contributor Author

Hi @shrielenee I have merged #2179 to #2178

@shrielenee shrielenee removed the Waiting for Response Waiting for response from internal/external parties label Jun 12, 2018
@shrielenee shrielenee merged commit 105bce0 into magento:develop Jun 12, 2018
@magento-engcom-team magento-engcom-team added the Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies label Jun 20, 2018
magento-cicd2 pushed a commit that referenced this pull request Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.1.x 2.2.x 2.3.x Magento 2.3 related changes Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants