Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

neeta-wagento
Copy link
Contributor

@neeta-wagento neeta-wagento commented Jun 15, 2018

This PR is a: Fix typos

  • New topic
  • Content fix or rewrite
  • Bug fix or improvement

Summary

Fix typos

When this pull request is merged, it will...

Additional information

@shrielenee shrielenee self-assigned this Jun 15, 2018
@shrielenee shrielenee mentioned this pull request Jun 19, 2018
3 tasks
@shrielenee
Copy link
Contributor

You should add changes from PR #2267 to this PR, and push back up for review. Please also ensure you're changing all applicable versions (if they aren't symlinked together).

@shrielenee shrielenee added the Waiting for Response Waiting for response from internal/external parties label Jun 19, 2018
@@ -40,10 +40,10 @@ Prior to setting up your workspace, you may want to gather the following credent

* **Magento Access Key**: Provides secure access through a 32-character authentication token. The token authenticates between your account, the Magento 2 code repo (repo.magento.com), and any other Git services like GitHub and 3rd party accounts needed for development. You can create multiple Magento access keys. For the workspace setup, you can start with one specific key for your code repository. To generate a key, contact the Project Owner to generate [Magento authentication keys]({{ page.baseurl }}/install-gde/prereq/connect-auth.html).
* **Cloud Project account**: The Project Owner or Technical Admin (Super User) should invite you to the {{site.data.var.ece}} project. When you receive the e-mail invitation, click the link and follow the prompts to create your account. See [Set up an account]({{ page.baseurl }}/cloud/before/before-workspace.html#newaccount) for details.
* **Magento Encryption Key**: When importing an existing Magento system only, you will need to capture the Magento encryption key used to protect your access and data for the Magento database. For details on this key, see [Resolve issues with encryption key]({{ page.baseurl }}/cloud/trouble/trouble-crypt-key-variable.html)
* **Magento Encryption Key**: When importing an existing Magento system only, you will need to capture the Magento encryption key used to protect your access and data for the Magento database. For details on this key, see [Resolve issues with an encryption key]({{ page.baseurl }}/cloud/trouble/trouble-crypt-key-variable.html)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change isn't relevant, as "Resolve issues with encryption key" is the actual name of the page. Please revert.

@shrielenee shrielenee added Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies 2.1.x 2.2.x 2.3.x Magento 2.3 related changes labels Jun 20, 2018
@neeta-wagento
Copy link
Contributor Author

Hello @shrielenee
I have added the changes! Kindly review and confirm.

Thank you!

@shrielenee shrielenee removed the Waiting for Response Waiting for response from internal/external parties label Jun 21, 2018
@shrielenee
Copy link
Contributor

Thanks for making these changes @neeta-wagento!

@shrielenee shrielenee merged commit a090860 into magento:develop Jun 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.1.x 2.2.x 2.3.x Magento 2.3 related changes Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants