Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

chirag-wagento
Copy link
Contributor

@chirag-wagento chirag-wagento commented Jun 21, 2018

This PR is a:

  • New topic
  • Content fix or rewrite
  • Bug fix or improvement

Summary

Fixes typo
When this pull request is merged, it will...

Additional information

@shrielenee shrielenee self-assigned this Jun 21, 2018
@@ -34,7 +34,7 @@ Guest user | Resources with `anonymous` permission.

<h3 id="acl-webapi-relation">Relation between acl.xml and webapi.xml</h3>
The <code>acl.xml</code> file defines the access control list (ACL) for a given {% glossarytooltip c1e4242b-1f1a-44c3-9d72-1d5b1435e142 %}module{% endglossarytooltip %}. It defines available set of permissions to access the resources.
`acl.xml` files across all Magento modules are consolidated to build an ACL tree which is used to select allowed {% glossarytooltip 29ddb393-ca22-4df9-a8d4-0024d75739b1 %}Admin{% endglossarytooltip %} role resources or third party Integration's access (System > {% glossarytooltip 55774db9-bf9d-40f3-83db-b10cc5ae3b68 %}Extension{% endglossarytooltip %} > Integration > Add New Integration > Available APIs).
`acl.xml` files across all Magento modules are consolidated to build an ACL tree which is used to select allowed {% glossarytooltip 29ddb393-ca22-4df9-a8d4-0024d75739b1 %}Admin{% endglossarytooltip %} role resources or third party Integration's access (<b>System > Extension > Integration > Add New Integration > Available APIs</b>).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use markdown for text formatting. Please replace <b> with ** surrounding what you want to be bold.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any other places that you can convert HTML formatting to markdown formatting is also good!

@shrielenee shrielenee added Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies Waiting for Response Waiting for response from internal/external parties 2.1.x 2.2.x 2.3.x Magento 2.3 related changes labels Jun 21, 2018
@chirag-wagento
Copy link
Contributor Author

@shrielenee As per your advice i have committed new code please check it.

Thanks

@shrielenee
Copy link
Contributor

Great job! Thanks @chirag-wagento!

@shrielenee shrielenee removed the Waiting for Response Waiting for response from internal/external parties label Jun 22, 2018
@shrielenee shrielenee merged commit a873ebb into magento:develop Jun 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.1.x 2.2.x 2.3.x Magento 2.3 related changes Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants