Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

dshevtsov
Copy link
Collaborator

@dshevtsov dshevtsov commented Dec 10, 2018

This PR is a:

  • Content update

Summary

When this pull request is merged, it will update Metadata topic with more details about referencing to data from url of an <operation> and in <value> of an <array>.

whatsnew
MFTF 2.3.12 was released:

  • Added more documentation with examples for <value> in metadata array.
  • Added use of reference to data field in url of metadata operation.

@dshevtsov dshevtsov added Major Update Significant original updates to existing content 2.2.x 2.3.x Magento 2.3 related changes labels Dec 10, 2018
@dshevtsov dshevtsov self-assigned this Dec 10, 2018
Example:
1. The `dataType` value must match the `type` value of the corresponding entity.
2. The file name contains data type split with `_` and ends with `-meta`.
Example: `product_attribute-meta.xml`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file name can be anything but needs to ends with -meta. We use data type a lot by convention.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will change to:
The file name should contain data type split with _ and must end with -meta.

- \*`url` - full URL is a concatenation of _ENV.baseUrl_ + `/rest/` + _url_.
To reuse data of a required entity or returned response use a field key wrapped in curly braces such as `{sku}`.
When the data to reuse is of a different type, declare also the type of data such as `{product.sku}`.
Examples: `"/V1/products/{sku}/media/{id}"`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing type? should be
Examples: "/V1/products/{product.sku}/media/{id}".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

content="GET is used for retrieving data from objects.<br/>
POST is used for creating new objects.<br/>
PUT is used for updating objects.<br/>
DELETE is used for deleting objects.<br/>" %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DELETE is removed. Is this on purpose?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this text duplicates the text above in this topic


It contains one or more `value` elements.

### value {#value-tag}

An item in `array`.
Declares a data type of the parent array items.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the array itself. Not parent array.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with comments

@dobooth dobooth assigned dobooth and unassigned dshevtsov Dec 20, 2018
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Dec 20, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 6 committers have signed the CLA.

✅ dshevtsov
✅ jilu1
✅ dobooth
✅ lorikrell
❌ Donald Booth
❌ --global


Donald Booth, --global seem not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@dobooth dobooth requested a review from erikmarr December 20, 2018 21:56
@dshevtsov dshevtsov requested a review from lorikrell December 21, 2018 15:29
Copy link

@lorikrell lorikrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I only had a couple minor edits and questions.

An item in `array`.
Declares a data type for items within `<array>`.

1. Example of an array with value of a primitive data type:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General question, should these be in a numbered list? Is there a specific task they are completing with the steps? Or you can remove the numbering and keep the bullets under each example.

@dobooth
Copy link
Contributor

dobooth commented Dec 21, 2018

running tests

@dobooth dobooth merged commit 5bcd2dc into master Dec 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.2.x 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants