This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Improved custom indexer code and description #3465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An admin must run tests on this PR before it can be merged. |
osrecio
reviewed
Dec 14, 2018
osrecio
approved these changes
Dec 14, 2018
There was a problem hiding this comment.
Hi @gelanivishal , For me the PR is Ok, someone from Magento will run the tests and if all is OK we will merge your PR ASAP.
Thanks for your contribution!
|
Thanks @osrecio ! Checking it out. :) |
lorikrell
suggested changes
Dec 14, 2018
There was a problem hiding this comment.
@gelanivishal This looks fantastic! I have only tiny edit suggestions! If you don't mind checking those, I'll get this tested and merged.
Co-Authored-By: gelanivishal <vishalgelani99@gmail.com>
Co-Authored-By: gelanivishal <vishalgelani99@gmail.com>
Co-Authored-By: gelanivishal <vishalgelani99@gmail.com>
|
@lorikrell I have committed your suggestions |
lorikrell
approved these changes
Dec 14, 2018
There was a problem hiding this comment.
Thanks again @gelanivishal for the great contributions! I'll run tests and merge today.
|
running tests |
lorikrell
added
2.3.x
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a:
Summary
I have improved custom indexer code and description also added each parameter detail of using in xml also given an example by image.
When this pull request is merged, it will...
Additional information
List all affected URLs
whatsnew
Improved custom indexer code and information in Adding a custom indexer.