This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Updated CLI docs for compilation process #3466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An admin must run tests on this PR before it can be merged. |
lorikrell
suggested changes
Dec 14, 2018
There was a problem hiding this comment.
@gelanivishal Thank you so much for the PR! I slightly revised your note to flip around the content, just to help developers understand what mode displaying the message. If these work for you, feel free to accept or edit further. :) I'll watch for your thoughts and edits. Then will run tests and merge!
lorikrell
added
2.2.x
2.3.x
Co-Authored-By: gelanivishal <vishalgelani99@gmail.com>
Co-Authored-By: gelanivishal <vishalgelani99@gmail.com>
Co-Authored-By: gelanivishal <vishalgelani99@gmail.com>
Co-Authored-By: gelanivishal <vishalgelani99@gmail.com>
Co-Authored-By: gelanivishal <vishalgelani99@gmail.com>
Co-Authored-By: gelanivishal <vishalgelani99@gmail.com>
Co-Authored-By: gelanivishal <vishalgelani99@gmail.com>
Co-Authored-By: gelanivishal <vishalgelani99@gmail.com>
Co-Authored-By: gelanivishal <vishalgelani99@gmail.com>
Co-Authored-By: gelanivishal <vishalgelani99@gmail.com>
Co-Authored-By: gelanivishal <vishalgelani99@gmail.com>
Co-Authored-By: gelanivishal <vishalgelani99@gmail.com>
Co-Authored-By: gelanivishal <vishalgelani99@gmail.com>
Co-Authored-By: gelanivishal <vishalgelani99@gmail.com>
|
@lorikrell I have updated your suggestions |
lorikrell
approved these changes
Dec 14, 2018
There was a problem hiding this comment.
Thank you @gelanivishal ! Running tests and merging, should have it done today. :) Thanks for the great contribution.
|
running tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a:
Summary
I have added that the
magento setup:upgradecommand no longer prompts to runsetup:di:compileif Magento is in developer modeWhen this pull request is merged, it will fixed #2189
Additional information
List all affected URLs
whatsnew
Added information for the
setup:di:compilestep for Install extensions from the command line, Install the B2B extension, and Create an integration.