Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

meker12
Copy link
Contributor

@meker12 meker12 commented Dec 17, 2018

@meker12 meker12 added 2.1.x Major Update Significant original updates to existing content 2.2.x 2.3.x Magento 2.3 related changes labels Dec 17, 2018
@meker12 meker12 self-assigned this Dec 17, 2018

If you have an existing Fastly account that has been configured with the same apex and sub-domains used for your {{ site.data.var.ece }} project, remove those domains from your Fastly account before submitting the request to add Fastly services to your project environments. See [Working with Domains](https://docs.fastly.com/guides/basic-configuration/working-with-domains) in the Fastly documentation.

**DNS delegation**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like some clarification on this section. I'll meet with you to discuss, @meker12

subdomains of shoes.mystore.com and socks.mystore.com managed by an existing
Fastly account, you need to remove them from that account before going live with
Fastly and {{site.data.var.ece}}.
{{ site.data.var.ece }} projects do not require a dedicated Fastly account or account owner. Instead, each project environment has its own set of Fastly credentials (API key and service ID) that you use to configure and manage Fastly services from the Magento Admin UI. You also use these credentials to submit requests to the Fastly API service.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace "its own set" with "a set" or something better.


We'll provide you with the following credentials for your Staging and Production
services:
- For Pro projects, include the origin URLs for your Production and Staging sites.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Origin is in caps in some places. Is this a reference to the Origin shields or is it a reference to a particular remote?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an inherited sentence -- it's actually referring to the site URLs ... so origin is not correct here.

file in that location. If you do not locate this file, please enter a ticket
for [Support]({{ page.baseurl }}/cloud/trouble/trouble.html) asking to have the
file added. We can help provide this credentials file.
If the domains included in your Cloud project are associated with an existing Fastly service account, see [Multiple Fastly accounts and assigned domains](#domain).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems choppy. Maybe "If your project domains link to an existing..."


### Multiple Fastly accounts and assigned domains {#domain}

If you have an existing Fastly account that has been configured with the same apex and sub-domains used for your {{ site.data.var.ece }} project, remove those domains from your Fastly account before submitting the request to add Fastly services to your project environments. See [Working with Domains](https://docs.fastly.com/guides/basic-configuration/working-with-domains) in the Fastly documentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need "that has been".

For details, review your Fastly accounts and [documentation](https://docs.fastly.com/)
to remove the domains. This may include removing and updating CNAME records and
more.
To get these credentials, Magento needs to add your project environments to the Fastly service account for {{ site.data.var.ece }} and add the Fastly account credentials to your project environment configurations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When it says "add your project environments", does it mean you are adding a link?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes-- link is the right concept. Thanks.

@@ -258,12 +274,15 @@ handle your blog.
- us-west-1 => sjc-ca-us
- us-west-2 => sea-wa-us

4. Modify the timeout values (in microseconds for the connection to the
1. Modify the timeout values (in microseconds for the connection to the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

close the parenthesis

@@ -337,16 +362,21 @@ a Magento extension for GeoIP handling, you may need to verify the features with
Fastly options.

1. In the **Fastly Configuration** section, expand **Advanced**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locations are italicized and action elements are bold.


1. Click **Save Config** at the top of the page.

1. After page reload, click *Upload VCL to Fastly* in the *Fastly Configuration* section.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you click Upload VCL to Fastly, then it should be bold.

@@ -124,6 +125,13 @@ This displays the following page, which enables you to configure settings, [vari

![configure environments]({{ site.baseurl }}/common/images/cloud_project-conf-env.png)

### Environment configuration variables
On the Variables page, you can view, create, and manage environment variables for your project. For example, after we add your project to the {{ site.data.var.ece }} Fastly service account, you can view the Fastly API key and service ID credentials as shown in the following example.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variables is a tab.
Use a colon after example.


![Environment variables fastly credentials]({{ site.baseurl }}/common/images/cloud/cloud-project-web-ui-environment-variables.png)

You can also view environment variables using the Magento CLI `magento-cloud variable:get -e <environment ID>` command. See [List and review variables]({{ page.baseurl }}/cloud/before/before-setup-env-2_clone.html#variablelist).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also splits the verb...
This command is long enough that it is difficult to see in the sentence. It might be more user friendly if they are able to copy it using the Copy function of a code block.

Copy link
Contributor

@hguthrie hguthrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Merry Christmas!

@meker12
Copy link
Contributor Author

meker12 commented Dec 21, 2018

running tests

@meker12 meker12 merged commit 49bb429 into master Dec 21, 2018
@meker12 meker12 deleted the me-MAGECLOUD-2970-get-fastly-credentials branch December 21, 2018 21:53
@dshevtsov
Copy link
Collaborator

@meker12 please add whatsnew

@dshevtsov
Copy link
Collaborator

@meker12 please move whatsnew at the end of PR description

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.1.x 2.2.x 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants