Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

MAGEDOC-3399: Product availability update #3552

Merged
merged 2 commits into from
Jan 10, 2019

Conversation

jeff-matthews
Copy link
Contributor

@jeff-matthews jeff-matthews commented Jan 10, 2019

This PR is a:

  • New topic
  • Content update
  • Content fix or rewrite
  • Bug fix or improvement

Summary

When this pull request is merged, it will update the availability timeline for the Amazon Sales Channel extension.

Additional information

List all affected URLs

whatsnew
Updated the availability timeline for the Amazon Sales Channel extension.

@jeff-matthews jeff-matthews self-assigned this Jan 10, 2019
@jeff-matthews jeff-matthews added Major Update Significant original updates to existing content 2.x and removed 2.x labels Jan 10, 2019
@jeff-matthews
Copy link
Contributor Author

running tests

@jeff-matthews jeff-matthews merged commit 0fd3102 into master Jan 10, 2019
@jeff-matthews jeff-matthews deleted the MAGEDOC-3399-product-availability branch January 10, 2019 18:49
@dshevtsov
Copy link
Collaborator

@jeff-matthews please add labels with target versions

@jeff-matthews
Copy link
Contributor Author

@dshevtsov, this topic and these changes are not specific to core Commerce.

@dshevtsov
Copy link
Collaborator

@jeff-matthews in this case Versions cell will be empty in https://devdocs.magento.com/whats-new.html for this entry. Is it expected result?

@jeff-matthews
Copy link
Contributor Author

@dshevtsov, I don't think we ever considered this scenario when we first started publishing whatsnew. In this case, I would say it is expected. However, leaving the cell blank is not ideal. Do you have any suggestions?

@dshevtsov
Copy link
Collaborator

we can use N/A when version was not specified in a PR label.

@dshevtsov
Copy link
Collaborator

or 2.x that would mean that the update is generally applicable for Magento 2

@jeff-matthews
Copy link
Contributor Author

jeff-matthews commented Jan 14, 2019

I think N/A is an acceptable temporary solution. Have you considered how the whatsnew might change after we start publishing docs like PageBuilder? Perhaps we should consider adding some new labels to the repo. What do you think?

@dshevtsov
Copy link
Collaborator

A lot of open questions here, we will need to discuss them with projects teams.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Major Update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants