-
Notifications
You must be signed in to change notification settings - Fork 1.7k
MAGECLOUD-1581 change base template #3578
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few editorial suggestions
`.gitignore` | Specify which files and directories to ignore. See [`.gitignore` reference](#ignoring-files). | ||
`.magento.app.yaml` | Configuration file that defines the properties to build your application. See [Configure environments]({{ page.baseurl }}/cloud/env/environments.html). | ||
`.magento.env.yaml` | Configuration file that defines actions for the build, deploy, and post-deploy phases. The ece-tools package includes a sample of this file with detailed descriptions for the available variables. See [Configure environments]({{ page.baseurl }}/cloud/env/environments.html). | ||
`composer.json` | Fetches the Magento Enterprise Edition and the necessary configuration scripts to prepare your application. See [Prepare your Magento install]({{ page.baseurl }}/cloud/setup/first-time-setup-import-prepare.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title on the link text sounds odd: Prepare your existing Magento Commerce install -- the TOC title for this linked topic makes more sense: Prepare your existing Magento Commerce system (See https://devdocs.magento.com/guides/v2.3/cloud/setup/first-time-setup-import-prepare.html)
`.magento.env.yaml` | Configuration file that defines actions for the build, deploy, and post-deploy phases. The ece-tools package includes a sample of this file with detailed descriptions for the available variables. See [Configure environments]({{ page.baseurl }}/cloud/env/environments.html). | ||
`composer.json` | Fetches the Magento Enterprise Edition and the necessary configuration scripts to prepare your application. See [Prepare your Magento install]({{ page.baseurl }}/cloud/setup/first-time-setup-import-prepare.html). | ||
`composer.lock` | Stores version dependencies for every package. | ||
`magento-vars.php` | A file used to define [multiple stores]({{ page.baseurl }}/cloud/project/project-multi-sites.html#modify-the-magento-varsphp-file) and sites using [Magento variables]({{ page.baseurl }}/config-guide/multi-site/ms_over.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These link targets seem confusing ---
multiple stores ==> Modify the magento-vars.php
file topic in Cloud docs
Magento variables ==> Multiple websites or stores overview topic in Configuration Guide
Please check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine for the table. The Config guide link talks about the Admin UI and defining the Magento variables: Use the MAGE_RUN_TYPE and MAGE_RUN_CODE variables
The Cloud link explains the implementation for Cloud and you can see those variables in use.
runnings tests |
running tests |
Hi @hguthrie, thank you for your contribution! |
Completed a task to update the Project structure topic to include information on changing the base template.
whatsnew
Added section to Cloud Project structure about how to change the base template.