Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

magento-cloud ssh changed, so our instructions needed updating #3586

Merged

Conversation

simensen
Copy link
Contributor

@simensen simensen commented Jan 17, 2019

This PR is a:

  • New topic
  • Content update
  • Content fix or rewrite
  • Bug fix or improvement

Summary

When this pull request is merged, it will...

Show correct instructions accounting for changes to magento-cloud ssh command.

Additional information

List all affected URLs

  • /guides/v2.1/cloud/project/project-integrate-blackfire.html
  • /guides/v2.2/cloud/project/project-integrate-blackfire.html
  • /guides/v2.3/cloud/project/project-integrate-blackfire.html

whatsnew
Corrected the command syntax in the log preparation instructions for troubleshooting Blackfire issues.

@magento-cicd2
Copy link
Contributor

An admin must run tests on this PR before it can be merged.

@osrecio osrecio self-requested a review January 18, 2019 09:08
@osrecio osrecio self-assigned this Jan 18, 2019
Copy link
Member

@osrecio osrecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @simensen ,

I tested your PR in Magento Cloud and works finde.

Thanks for your update

@osrecio
Copy link
Member

osrecio commented Jan 18, 2019

Screenshot of test in my local enviroment with same approach (different command but same result)
screenshot 2019-01-18 at 10 07 30

@jeff-matthews jeff-matthews added Technical Updates to the code or processes that alter the technical content of the doc 2.x labels Jan 18, 2019
@meker12
Copy link
Contributor

meker12 commented Jan 18, 2019

running tests

@osrecio
Copy link
Member

osrecio commented Jan 23, 2019

Hi @meker12 Can I help you with something related with Tests?
Thanks!

@hguthrie
Copy link
Contributor

running tests

@hguthrie hguthrie merged commit b6ea300 into magento:master Jan 30, 2019
@ghost
Copy link

ghost commented Jan 30, 2019

Hi @simensen, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.x Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants