Remove obsolete release notes #3595
Conversation
Fixes issue #3594
meker12
added
Editorial
| - Cloud | ||
| - Setup | ||
| - Configuration | ||
| redirect_from: |
There was a problem hiding this comment.
does this need a redirect for the 2.2 one also?
There was a problem hiding this comment.
Version 2.2 already redirects here: https://devdocs.magento.com/guides/v2.2/cloud/release-notes/CloudReleaseNotes2.2.html
I am thinking that that topic is also obsolete -- and I should remove it.
Then add two redirects to the v2.2 cloud-tools.md topic:
https://devdocs.magento.com/guides/v2.2/cloud/release-notes/CloudReleaseNotes2.2.html
https://devdocs.magento.com/guides/v2.2/cloud/release-notes/CloudReleaseNotes.html
There was a problem hiding this comment.
After looking deeper into this, I do not believe we should delete the older versions of this file. Those release notes have nothing to do with the ECE-tools release notes. It is perfectly fine to delete or redirect the offending 2.3 placeholder file, but the others should remain or be archived. They were legit for their particular release AND they are reference in the Magento Commerce release notes. @jeff-matthews (Copying you because you commented on the original issue.)
There was a problem hiding this comment.
I moved the redirect directive for the v2.2 /cloud/release-notes/CloudReleaseNotes.html to the (v2.2/cloud/release-notes/CloudReleaseNotes2.2.md).
There was a problem hiding this comment.
I agree that we should not delete https://devdocs.magento.com/guides/v2.2/cloud/release-notes/CloudReleaseNotes2.2.html. I'm more concerned with the empty files.
We should add a link to the new release notes in that file though to help guide users who land there from google search.
We should also investigate adding a link to the new release notes to this page as requested in the issue linked to this PR: https://devdocs.magento.com/guides/v2.3/release-notes/bk-release-notes.html.
| - Cloud | ||
| - Setup | ||
| - Configuration | ||
| redirect_from: |
There was a problem hiding this comment.
I agree that we should not delete https://devdocs.magento.com/guides/v2.2/cloud/release-notes/CloudReleaseNotes2.2.html. I'm more concerned with the empty files.
We should add a link to the new release notes in that file though to help guide users who land there from google search.
We should also investigate adding a link to the new release notes to this page as requested in the issue linked to this PR: https://devdocs.magento.com/guides/v2.3/release-notes/bk-release-notes.html.
|
running tests |
|
Hi @meker12, thank you for your contribution! |
|
I think this may have caused a bug. @meker12 @jeff-matthews could you confirm that you see double? I was trying to figure out what happened, but it's strange. https://devdocs.magento.com/guides/v2.2/cloud/release-notes/cloud-tools.html |
|
Yikes! Yep, you're right @hguthrie. The on-page nav seems to be duplicated. |
|
I fixed it. I saw some dashes mixed in, so it was either a conflict resolution that wasn't completely cleaned up or a simple cut and paste error. |
|
Thanks for catching and fixing @hguthrie. |
|
@meker12 , Liquid variables don't work in whatsnew. |
Fixes #3594
This PR is a:
Summary
Additional information
*Affected URLs *
https://devdocs.magento.com/guides/v2.1/cloud/release-notes/CloudReleaseNotes.html
https://devdocs.magento.com/guides/v2.2/cloud/release-notes/CloudReleaseNotes.html
https://devdocs.magento.com/guides/v2.3/cloud/release-notes/CloudReleaseNotes.html
https://devdocs.magento.com/guides/v2.2/cloud/release-notes/CloudReleaseNotes2.2.html
https://devdocs.magento.com/guides/v2.3/cloud/release-notes/CloudReleaseNotes2.2.html
https://devdocs.magento.com/guides/v2.2/release-notes/bk-release-notes.html
https://devdocs.magento.com/guides/v2.3/release-notes/bk-release-notes.html
https://devdocs.magento.com/guides/v2.1/cloud/release-notes/cloud-tools.html
https://devdocs.magento.com/guides/v2.2/cloud/release-notes/cloud-tools.html
https://devdocs.magento.com/guides/v2.3/cloud/release-notes/cloud-tools.html
whatsnew
Updated Magento Commerce and Magento Commerce Cloud release information to remove obsolete topics and add links to current Magento Commerce Cloud release information in Release Notes for ece-tools.