Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

ronak2ram
Copy link
Member

@ronak2ram ronak2ram commented Feb 17, 2019

This PR is a:

  • New topic
  • Content update
  • Content fix or rewrite
  • Bug fix or improvement

Summary

When this pull request is merged, it will show updated sales resources.
magento/magento2#20542
magento/magento2#20170

Additional information

List all affected URLs

@magento-cicd2
Copy link
Contributor

An admin must run tests on this PR before it can be merged.

@keharper
Copy link
Contributor

@dshevtsov I'm assigning this to you because you know how the MRG is generated. The changes look accurate.

The development PR definitely needs a release note. I'll make sure @jfrontain knows.

@jeff-matthews jeff-matthews added xx2.3.1 Magento 2.3.1 changes Technical Updates to the code or processes that alter the technical content of the doc labels Feb 19, 2019
@dshevtsov dshevtsov requested a review from akaplya February 19, 2019 16:30
@dshevtsov
Copy link
Collaborator

dshevtsov commented Feb 25, 2019

@keharper the MRG in 2.2 is not automated
for changes in 2.3, we will need to discuss how to do this, but it is out of scope for this PR

@dshevtsov dshevtsov requested a review from keharper February 25, 2019 19:22
@dshevtsov dshevtsov assigned keharper and unassigned dshevtsov Feb 25, 2019
@dshevtsov dshevtsov requested review from dshevtsov and removed request for keharper February 25, 2019 19:27
@keharper keharper merged commit ead654d into magento:2.3.1-integration Feb 25, 2019
@ghost
Copy link

ghost commented Feb 25, 2019

Hi @ronak2ram, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Partner: Krish TechnoLabs partners-contribution PR created by Magento partner Technical Updates to the code or processes that alter the technical content of the doc xx2.3.1 Magento 2.3.1 changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants